Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Pre Ruby 3.4 updates #7536

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Chore: Pre Ruby 3.4 updates #7536

merged 1 commit into from
Dec 13, 2024

Conversation

colinbruce
Copy link
Contributor

What

I pulled down a release candidate of ruby 3.4 to see how "bad" the transition could be, and the only, obvious, issue was these two files requiring RSpec.

As they are a superfluous require and Rails was not able to open a console and rspec would not run with these present in 3.4, they can be removed now

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

I pulled down a release candidate of ruby 3.4 to see how
"bad" the transition could be, and the only, obvious,
issue was these two files requiring RSpec.

Rails would not open a console and rspec would not run
with these present
@colinbruce colinbruce marked this pull request as ready for review December 13, 2024 10:50
@colinbruce colinbruce requested a review from a team as a code owner December 13, 2024 10:50
@colinbruce colinbruce added the ready for review Please review label Dec 13, 2024
@jsugarman jsugarman added approved Approved by code reviewers and removed ready for review Please review labels Dec 13, 2024
@colinbruce colinbruce merged commit 3c8ed6e into main Dec 13, 2024
16 checks passed
@colinbruce colinbruce deleted the chore/pre-ruby-3.4-fixes branch December 13, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants