Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ap-5378-amend-specific-issue-at-court-question #7523

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

skdejong
Copy link
Contributor

What

Amend to existing “What specific issue do you want to determine at court” question

Remove the text “I confirm this specific issue proceeding is not for a change of name application” and the checkbox for all proceedings. This is because we have added a question to the proceeding loop instead to confirm that the application is not for a change of name.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@skdejong skdejong added the WIP Work In Progress label Dec 10, 2024
@skdejong skdejong marked this pull request as ready for review December 11, 2024 08:35
@skdejong skdejong requested a review from a team as a code owner December 11, 2024 08:35
@skdejong skdejong added ready for review Please review and removed WIP Work In Progress labels Dec 11, 2024
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skdejong skdejong added UAT approved Approved by code reviewers ready for review Please review Ready to merge Has passed UAT testing and can be merged into master and removed ready for review Please review UAT labels Dec 11, 2024
@skdejong skdejong force-pushed the ap-5378-amend-specific-issue-at-court-question branch from 564c1a0 to 4f2bc30 Compare December 13, 2024 10:00
@skdejong skdejong merged commit be4eefb into main Dec 13, 2024
15 checks passed
@skdejong skdejong deleted the ap-5378-amend-specific-issue-at-court-question branch December 13, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers Ready to merge Has passed UAT testing and can be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants