Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(APG-315) Update RIsks and Needs Section 7 - Lifestyle #709

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

jsrobertson
Copy link
Contributor

@jsrobertson jsrobertson commented Aug 16, 2024

Context

We need to add the extra OASys fields used to calculate the PNI to the front-end.

Changes in this PR

  • Added a new summary list for Section 7.3 - Criminal associates
  • Used Lifestyle type from the imported file as we look to move away from using @accredited-programmes/models

Screenshots of UI changes

image

Release checklist

Release process documentation

As part of our continuous deployment strategy we must ensure that this work is
ready to be released once merged.

Pre-merge

  • There are changes required to the Accredited Programmes API for this change to work...
    • ... and they have been released to production already

Post-merge

  • This adds, extends or meaningfully modifies a feature...
  • This makes new expectations of the API...
    • ... and I have notified the API developer(s) of changes to the contract tests (Pact), or the API is already compliant
  • Manually approve release to preprod
  • Manually approve release to prod

@jsrobertson jsrobertson marked this pull request as ready for review August 16, 2024 07:28
@jsrobertson jsrobertson merged commit 85e1781 into main Aug 16, 2024
8 checks passed
@jsrobertson jsrobertson deleted the APG-315-section-7-updates branch August 16, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants