Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an external collaborator #2084

Merged
merged 4 commits into from
May 31, 2024
Merged

Add an external collaborator #2084

merged 4 commits into from
May 31, 2024

Conversation

andyrogers1973
Copy link
Contributor

Gregory Whiting will be given access to yjaf-terraform repo

Issue #2083

Gregory Whiting will be given access to yjaf-terraform repo
@andyrogers1973 andyrogers1973 requested a review from a team as a code owner May 30, 2024 14:39
Fixes a typo in the approvers email address (causing check to fail)
Approvers email address still had a typo casuing check to fail
Copy link
Contributor

@tamsinforbes tamsinforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting clarification on access level required

terraform/yjaf-terraform.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@AntonyBishop AntonyBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't be the added_by user. Access need to be authorised by David.Hall@yjb.gov.uk

Changed the email address of the added by user to the correct user.
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@tamsinforbes tamsinforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Received approval via David Halls deputies.

@tamsinforbes tamsinforbes dismissed AntonyBishop’s stale review May 31, 2024 10:45

Requested changes made

@tamsinforbes tamsinforbes merged commit f61f6ea into main May 31, 2024
14 checks passed
@tamsinforbes tamsinforbes deleted the add-gregory-whiting branch May 31, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants