-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dp 3072 data product detail page #92
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murdo-moj
reviewed
Feb 22, 2024
MatMoore
reviewed
Feb 22, 2024
murdo-moj
reviewed
Feb 22, 2024
murdo-moj
reviewed
Feb 22, 2024
LavMatt
force-pushed
the
dp-3072-data-product-detail-page
branch
from
February 22, 2024 15:18
e48cd3b
to
6960348
Compare
murdo-moj
previously approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selenium tests are broken but we'll fix this in a later commit
murdo-moj
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: ministryofjustice/analytical-platform#3072
Adds the data product details page to find-moj-data.
Includes:
DetailsDataProductService
to create data product details page contextministryofjustice-data-platform-catalogue
version for addedlist_data_product_assets()
search method and some other bug fixes.This does not add pagination to the details of a data product, although this may want to e considered for another issue. e.g. when a data product has a large amount of associated assets