Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dp 3072 data product detail page #92

Merged
merged 15 commits into from
Feb 26, 2024
Merged

Conversation

LavMatt
Copy link
Contributor

@LavMatt LavMatt commented Feb 21, 2024

For: ministryofjustice/analytical-platform#3072
Adds the data product details page to find-moj-data.

Includes:

  • New specific html template for data product details page
  • An extra arg in the href of a search link to details to establish result type and redirect to correct details service in views
  • A DetailsDataProductService to create data product details page context
  • new ministryofjustice-data-platform-catalogue version for added list_data_product_assets() search method and some other bug fixes.
  • Tests for added functionality

This does not add pagination to the details of a data product, although this may want to e considered for another issue. e.g. when a data product has a large amount of associated assets

home/service/details.py Show resolved Hide resolved
home/views.py Outdated Show resolved Hide resolved
templates/details_data_product.html Outdated Show resolved Hide resolved
templates/details_data_product.html Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/selenium/conftest.py Show resolved Hide resolved
home/service/details.py Outdated Show resolved Hide resolved
@LavMatt LavMatt force-pushed the dp-3072-data-product-detail-page branch from e48cd3b to 6960348 Compare February 22, 2024 15:18
murdo-moj
murdo-moj previously approved these changes Feb 26, 2024
Copy link
Contributor

@murdo-moj murdo-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selenium tests are broken but we'll fix this in a later commit

@LavMatt LavMatt merged commit 6048171 into main Feb 26, 2024
3 checks passed
@LavMatt LavMatt deleted the dp-3072-data-product-detail-page branch February 26, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate detail page for a data product
3 participants