Bump to gov_uk_date_fields gem (inputmode)
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recommended way to use the numeric inputs is to be of type `text` but with pattern and inputmode attributes. The dates gem has been updated to produce this new markup [0] following the reports of issues with previous markup [1]. Also updated the `conviction_length` step to produce an input of type `text`, instead of number, and add the `inputmode` attribute. [0] https://github.com/ministryofjustice/gov_uk_date_fields/releases/tag/v4.1.0 [1] alphagov/govuk-frontend#1449
solidgoldpig
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommended way to use the numeric inputs is to be of type
textbut with pattern and inputmode attributes.The dates gem has been updated to produce this new markup [0] following the reports of issues with previous markup [1].
Also updated the
conviction_lengthstep to produce an input of typetext, instead of number, and add theinputmodeattribute.[0] https://github.com/ministryofjustice/gov_uk_date_fields/releases/tag/v4.1.0
[1] alphagov/govuk-frontend#1449