Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webdrivers gem #2081

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Upgrade webdrivers gem #2081

merged 3 commits into from
Oct 13, 2022

Conversation

vertism
Copy link
Contributor

@vertism vertism commented Oct 11, 2022

Description

webdrivers 5.0.0 has a bug on M1 macs where it uses the wrong naming convention when trying to download chromedriver (titusfortner/webdrivers#237). This is fixed in 5.2.0.

Self-review checklist

  • (1) Quick stakeholder demo done OR
  • (2) ...bug with before and after screenshots
  • (3) Tests passing
  • (4) Branch ready to be merged (not work in progress)
  • (5) No superfluous changes in diff
  • (6) No TODO's without new ticket numbers
  • (7) PR Prefixed with ticket number e.g. CT-7654 ...
  • (8) Data migration script is created if any of letter templates is changed

Screenshots

Related JIRA tickets

Deployment

Manual testing instructions

@vertism vertism requested a review from a team as a code owner October 11, 2022 08:15
Copy link
Contributor

@Polsonby Polsonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@vertism vertism merged commit 63c04c2 into main Oct 13, 2022
@vertism vertism deleted the upgrade-webdrivers-5-2 branch October 13, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants