perf: ⚡️ call GetAllNodes once (#613)

* perf: ⚡️ call GetAllNodes once
ministryofjustice · Aug 28, 2024 · 28268c7 · 28268c7
1 parent 6568252
commit 28268c7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/pkg/cluster/cluster.go b/pkg/cluster/cluster.go
@@ -62,7 +62,7 @@ func NewCluster(c *client.KubeClient) (*Cluster, error) {
 		return nil, err
 	}
 
-	oldestNode, err := getOldestNode(c)
+	oldestNode, err := oldestNode(nodes)
 	if err != nil {
 		return nil, err
 	}

diff --git a/pkg/cluster/node.go b/pkg/cluster/node.go
@@ -90,7 +90,6 @@ func GetAllNodes(c *client.KubeClient) ([]v1.Node, error) {
 	return n, nil
 }
 
-// getOldestNode returns the oldest node in a cluster
 func getOldestNode(c *client.KubeClient) (v1.Node, error) {
 	nodes, err := GetAllNodes(c)
 	if err != nil {

diff --git a/pkg/util/testutils.go b/pkg/util/testutils.go
@@ -1,7 +1,6 @@
 package util
 
 import (
-	"fmt"
 	"os"
 	"strings"
 	"testing"
@@ -14,7 +13,7 @@ func FileContainsString(t *testing.T, filename string, searchString string) {
 	}
 
 	if !(strings.Contains(string(contents), searchString)) {
-		t.Errorf(fmt.Sprintf("Didn't find string: %s in file: %s", searchString, filename))
+		t.Errorf("Didn't find string: %s in file: %s", searchString, filename)
 	}
 }