Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpu node pool and nvidia-driver daemonset in prod #4387

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

AntFMoJ
Copy link
Contributor

@AntFMoJ AntFMoJ commented May 22, 2024

Pull Request Objective

This piece of work is being tracked in this GitHub Issue.

The changes in this PR add a GPU-enable node group to the cluster in analytical-platform-production.
It also creates daemonset for the nvidia-device-plugin via yaml.

Note: Static analysis has been overridden as most of the issues flagged in the production cluster are historic and not arising from the changes made in this PR. A decision has been made to bypass the SA issues in the nvidia-device-plugin.yml for the time being.

Copy link
Contributor

github-actions bot commented May 22, 2024

Terraform Component 🧱: aws-analytical-platform-production-cluster

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @AntFMoJ, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_static_analysis

Copy link
Contributor

github-actions bot commented May 22, 2024

Terraform Component 🧱: aws-analytical-platform-production-cluster

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @AntFMoJ, Action: pull_request, Working Directory: terraform/aws/analytical-platform-production/cluster, Workflow: Terraform, Marker: aws-analytical-platform-production-cluster_plan

@AntFMoJ AntFMoJ marked this pull request as ready for review May 23, 2024 09:15
@AntFMoJ AntFMoJ requested a review from a team as a code owner May 23, 2024 09:15
Copy link
Member

@jacobwoffenden jacobwoffenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntFMoJ AntFMoJ merged commit 8689550 into main May 23, 2024
14 checks passed
@AntFMoJ AntFMoJ deleted the gpu-node-prod branch May 23, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants