Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Set BOLD egress KMS keys to multi region #4106

Merged
merged 1 commit into from
Apr 17, 2024
Merged

🌐 Set BOLD egress KMS keys to multi region #4106

merged 1 commit into from
Apr 17, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Apr 17, 2024 •
edited
Loading

This pull request:

  • Sets s3/mojap-data-production-bold-egress-* to multi region, this is required because Airflow runs in eu-west-1 but Analytical Platform new resources run in eu-west-2

Signed-off-by: Jacob Woffenden jacob.woffenden@digital.justice.gov.uk

Set BOLD egress keys to multi region
c11636f 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden added the do-not-merge Don't merge yet! label Apr 17, 2024
@jacobwoffenden jacobwoffenden self-assigned this Apr 17, 2024
@jacobwoffenden jacobwoffenden requested a review from a team April 17, 2024 12:12
@github-actions GitHub Actions
Copy link
Contributor

Terraform Component 🧱: aws-analytical-platform-data-production-ingestion-egress

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/ingestion-egress, Workflow: Terraform, Marker: aws-analytical-platform-data-production-ingestion-egress_plan

@github-actions GitHub Actions
Copy link
Contributor

Terraform Component 🧱: aws-analytical-platform-data-production-ingestion-egress

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/ingestion-egress, Workflow: Terraform, Marker: aws-analytical-platform-data-production-ingestion-egress_static_analysis

michaeljcollinsuk
michaeljcollinsuk approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit f6aed91 into main Apr 17, 2024
16 checks passed
@jacobwoffenden jacobwoffenden deleted the feat/regional-kms-for-bold branch April 17, 2024 15:03
@jacobwoffenden jacobwoffenden mentioned this pull request Apr 17, 2024
Closed
6 tasks
hjribeiro-moj pushed a commit that referenced this pull request Apr 23, 2024
@hjribeiro-moj
🌐 Set BOLD egress KMS keys to multi region (#4106)
3f9be47 
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljcollinsuk michaeljcollinsuk michaeljcollinsuk approved these changes

Assignees

@jacobwoffenden jacobwoffenden

Labels
do-not-merge Don't merge yet!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobwoffenden @michaeljcollinsuk