Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixing Glue Policy Size #4015

Merged
merged 1 commit into from
Apr 10, 2024
Merged

🐛 Fixing Glue Policy Size #4015

merged 1 commit into from
Apr 10, 2024

Conversation

julialawrence
Copy link
Contributor

Pull Request Objective

This piece of work is being tracked in #3765

The previous iteration of this policy was too long.

The policy as it was defined in the previous PR, exempted a list of roles and the entire account from database protection. After a closer examination of the original policy as well as this doc, it's more likely the intent was to specifically to exclude the account root user. The separate condition block exempting all account principals has been removed, and root account re-added

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Copy link
Contributor

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_static_analysis

Copy link
Contributor

Terraform Component 🧱: aws-analytical-platform-data-production-data-engineering-pipelines

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/data-engineering-pipelines, Workflow: Terraform, Marker: aws-analytical-platform-data-production-data-engineering-pipelines_plan

@julialawrence julialawrence marked this pull request as ready for review April 10, 2024 13:26
@julialawrence julialawrence requested a review from a team April 10, 2024 13:26
Copy link
Member

@jacobwoffenden jacobwoffenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fire in the hole

@julialawrence julialawrence merged commit 16ca040 into main Apr 10, 2024
14 checks passed
@julialawrence julialawrence deleted the feature/import-s-buckets branch April 10, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants