-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛂 cjs-dashboard-app GitHub Actions role #2974
Conversation
Update Dependabot Update path-filter Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Terraform Component 🧱:
|
Terraform Component 🧱:
|
terraform/aws/analytical-platform-data-production/cjs-dashboard-app/iam-policies.tf
Fixed
Show fixed
Hide fixed
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
…fjustice/data-platform into feature/cjs-dashboard-app-oidc
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Not a blocker to this, but out of interest do we know how the bucket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry was just taking a look at this PR as I lead on the CJS dashboard and not sure if anyone responded to your question @michaeljcollinsuk. The bucket was created/is managed by the data engineering exports repo as a pull dataset. This was required as we needed the bucket to sit on the AP but with its contents visible to a specific external user (our cloud platform app). |
This pull request:
ministryofjustice/cjs_scorecard_exploratory_analysis
access toarn:aws:s3:::mojap-cjs-dashboard
Note(s) for the reviewer:
github-actions-infrastructure
ordata-engineering-infrastructure
, which allow usage of theAdministratorAccess
policycreate-a-derived-table
, but we should look at consolidating them longer term 🏗️ Create a process for providing granular access to Analytical Platform data from GitHub Actions #2976Signed-off-by: Jacob Woffenden jacob.woffenden@digital.justice.gov.uk