Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛂 cjs-dashboard-app GitHub Actions role #2974

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Jan 17, 2024

This pull request:

  • Resolves ✨ Create new OIDC role for GitHub runner #2951
  • Adds a new component for cjs-dashboard-app in analytical-platform-data-production
  • Adds a policy and role to allow ministryofjustice/cjs_scorecard_exploratory_analysis access to arn:aws:s3:::mojap-cjs-dashboard

Note(s) for the reviewer:

Signed-off-by: Jacob Woffenden jacob.woffenden@digital.justice.gov.uk

Update Dependabot
Update path-filter

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden self-assigned this Jan 17, 2024
Copy link
Contributor

github-actions bot commented Jan 17, 2024

Terraform Component 🧱: aws-analytical-platform-data-production-cjs-dashboard-app

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/cjs-dashboard-app, Workflow: Terraform, Marker: aws-analytical-platform-data-production-cjs-dashboard-app_static_analysis

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Terraform Component 🧱: aws-analytical-platform-data-production-cjs-dashboard-app

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jacobwoffenden, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/cjs-dashboard-app, Workflow: Terraform, Marker: aws-analytical-platform-data-production-cjs-dashboard-app_plan

Jacob Woffenden added 3 commits January 17, 2024 12:31
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
…fjustice/data-platform into feature/cjs-dashboard-app-oidc
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden marked this pull request as ready for review January 17, 2024 12:41
@jacobwoffenden jacobwoffenden requested a review from a team January 17, 2024 12:41
@michaeljcollinsuk
Copy link
Contributor

michaeljcollinsuk commented Jan 17, 2024

Not a blocker to this, but out of interest do we know how the bucket mojap-cjs-dashboard was created/is managed? As does not appear to have been created in control panel (as does not have the alpha prefix and does not appear in the UI) and also cannot find reference to it being defined in terraform.

Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobwoffenden jacobwoffenden merged commit f2b6f17 into main Jan 17, 2024
20 checks passed
@jacobwoffenden jacobwoffenden deleted the feature/cjs-dashboard-app-oidc branch January 17, 2024 15:23
@laura-auburn
Copy link

Not a blocker to this, but out of interest do we know how the bucket mojap-cjs-dashboard was created/is managed? As does not appear to have been created in control panel (as does not have the alpha prefix and does not appear in the UI) and also cannot find reference to it being defined in terraform.

Sorry was just taking a look at this PR as I lead on the CJS dashboard and not sure if anyone responded to your question @michaeljcollinsuk. The bucket was created/is managed by the data engineering exports repo as a pull dataset. This was required as we needed the bucket to sit on the AP but with its contents visible to a specific external user (our cloud platform app).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Create new OIDC role for GitHub runner
4 participants