-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Create Initial Image #1
Conversation
Update CODEOWNERS Update Dependabot Update Dependency Review Add Scan Image Add Super-Linter Add Release (deactivated) Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add Build and Test workflow Add Build and Test script Add Container Structure Test definition Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Added jq Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Removed WIP files Add Python linting tools to dev container Added more tests Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add VS Code extensions Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add pyproject.toml Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Update Super-Linter Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
…al-platform-ingestion-scanner into initial-build
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Removed check from run_command Updated send_sns_message Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis that comments will be revisited at later time
This pull request:
The most notable file in this configuration is
src/var/task/handler.py
. This python file can be called in two modes -scan
anddefinition-upload
. As such this one container is called in two lambdas, one to keep theClamAV
virus definitions up-to-date, on a daily basis. And another which scans files usingClamAV
.📝 More detail is noted in this ticket.