Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Create Initial Image #1

Merged
merged 35 commits into from
Mar 12, 2024
Merged

🚀 Create Initial Image #1

merged 35 commits into from
Mar 12, 2024

Conversation

Gary-H9
Copy link
Contributor

@Gary-H9 Gary-H9 commented Mar 5, 2024

This pull request:

  • Adds standard repository structure for containers
  • Adds Dockerfile and source
  • Add devcontainer
  • Add linting config

The most notable file in this configuration is src/var/task/handler.py. This python file can be called in two modes - scan and definition-upload. As such this one container is called in two lambdas, one to keep the ClamAV virus definitions up-to-date, on a daily basis. And another which scans files using ClamAV.

📝 More detail is noted in this ticket.

@Gary-H9 Gary-H9 marked this pull request as draft March 5, 2024 17:38
Jacob Woffenden added 2 commits March 5, 2024 17:49
Update CODEOWNERS
Update Dependabot
Update Dependency Review
Add Scan Image
Add Super-Linter
Add Release (deactivated)

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add Build and Test workflow
Add Build and Test script
Add Container Structure Test definition

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Jacob Woffenden added 2 commits March 5, 2024 18:08
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Jacob Woffenden and others added 22 commits March 6, 2024 09:23
Added jq

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Removed WIP files
Add Python linting tools to dev container
Added more tests

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add VS Code extensions

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Add pyproject.toml

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Update Super-Linter

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@Gary-H9 Gary-H9 changed the title 🚧 Initial push - to be squashed later 🚀 Create Initial Image Mar 11, 2024
Jacob Woffenden added 5 commits March 11, 2024 11:29
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
…al-platform-ingestion-scanner into initial-build
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Removed check from run_command
Updated send_sns_message

Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
@jacobwoffenden jacobwoffenden marked this pull request as ready for review March 11, 2024 14:51
Jacob Woffenden added 2 commits March 12, 2024 09:29
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
Signed-off-by: Jacob Woffenden <jacob.woffenden@digital.justice.gov.uk>
src/var/task/handler.py Show resolved Hide resolved
src/var/task/handler.py Show resolved Hide resolved
src/var/task/handler.py Show resolved Hide resolved
src/var/task/handler.py Show resolved Hide resolved
src/var/task/handler.py Show resolved Hide resolved
src/var/task/handler.py Show resolved Hide resolved
Copy link

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that comments will be revisited at later time

@jacobwoffenden jacobwoffenden merged commit bed75b7 into main Mar 12, 2024
22 checks passed
@jacobwoffenden jacobwoffenden deleted the initial-build branch March 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants