Merge unreleased now only merges project-specific changes into each project.

[TheSpyder]

Closes #569

Check the following

• Keep 100% code coverage
• Be properly formatted
• Documentation changes are included
• Include a change file if expected

Additional context
The fix was so easy I decided to try my hand at my first PR in go 😅

The test I deleted was negated by #557, it's no longer possible to pass an invalid project to merge (since projects can't be passed at all). But when trying to write a test for this fix it confused me and made the process take longer than it should've - so I deleted it. Hope that's ok.

[miniscruff]

Good find, just need to run the formatter and that should be all

[TheSpyder]

Yeah I didn't remember to run the linter before opening the PR 🫣

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Files	Coverage Δ
cmd/merge.go	100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

[TheSpyder]

Interestingly make lint didn't fail on my test, it complains about core/utils_test.go. I had to run gofmt -s -w on each file I changed to figure out what was wrong.

[TheSpyder]

hmm, it seems the test I deleted was counting for some code coverage. Should I put it back?

[miniscruff]

Interestingly make lint didn't fail on my test, it complains about core/utils_test.go. I had to run gofmt -s -w on each file I changed to figure out what was wrong.

Hmm weird, I will take a look at the scripts to see why

[miniscruff]

hmm, it seems the test I deleted was counting for some code coverage. Should I put it back?

Yea, it's testing that one of the projects is configured wrong because the changelog path doesn't exist.

[TheSpyder]

Yea, it's testing that one of the projects is configured wrong because the changelog path doesn't exist

That's where the code is no longer covered, but the test is titled "invalid project" which is no longer necessary after the project config was removed. That's why I deleted it.
https://github.com/miniscruff/changie/pull/557/files#diff-fb89a4765053f1ffc1543a1d170f07c7da15bf932610ba3e67a186d1cc051c03L129

Mind if I rename it when I bring it back?

[miniscruff]

Yea, it's testing that one of the projects is configured wrong because the changelog path doesn't exist

That's where the code is no longer covered, but the test is titled "invalid project" which is no longer necessary after the project config was removed. That's why I deleted it.
https://github.com/miniscruff/changie/pull/557/files#diff-fb89a4765053f1ffc1543a1d170f07c7da15bf932610ba3e67a186d1cc051c03L129

Mind if I rename it when I bring it back?

Yea I think more specifically it's an invalid project config. So probably worth a rename.

[TheSpyder]

🤨

[2023-10-30T04:33:12.656Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/)
Error: There was an error fetching the storage URL during POST: 404 -
{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

[miniscruff]

🤨

[2023-10-30T04:33:12.656Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/)
Error: There was an error fetching the storage URL during POST: 404 -
{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

Usually I just retry it when this happens, never figured out why though.

[miniscruff]

I am going to quickly do a batch+merge ( kinda want to make an action for this ) to rollout the fix asap, thanks again.

[TheSpyder]

I'm starting to see a need for batch+merge myself, also some sort of equivalent to merge -u for batch in monorepos. I might start a ticket or discussion for that soon 🤔

[miniscruff]

I was thinking some comment based GitHub actions to run some stuff. Not sure yet.