Cast argument of snd_seq_dump_var_event #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids "error: passing argument 2 of ‘snd_seq_dump_var_event’ from incompatible pointer type" in sound/core/seq/oss/seq_oss_readq.c:146:36
|
Sorry, but your fix is wrong. You have to adapt the signature of I'll fix it up myself, no worries. Thanks for the report! |
minipli
added a commit
that referenced
this pull request
Nov 23, 2017
The second argument should be a const pointer under PaX/grsec. This fixes the following build breakage: sound/core/seq/oss/seq_oss_readq.c: In function ‘snd_seq_oss_readq_sysex’: sound/core/seq/oss/seq_oss_readq.c:146:36: error: passing argument 2 of ‘snd_seq_dump_var_event’ from incompatible pointer type [-Werror=incompatible-pointer-types] return snd_seq_dump_var_event(ev, readq_dump_sysex, &ctx); Reported-by: sempervictus in #14 Reported-by: powerman in #15 Signed-off-by: Mathias Krause <minipli@googlemail.com>
|
Thank you, will look up how you did it. We don't build for hardware with rap due to use of dkms, so this but never hit us on the virt builds which use it.
|
|
The RAP violation will only be triggered by executing this code path. Merely compiling/linking the code does not generate errors. ... RAP is CFI after all, i.e. needs a control flow, i.e. code execution ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids "error: passing argument 2 of ‘snd_seq_dump_var_event’
from incompatible pointer type" in
sound/core/seq/oss/seq_oss_readq.c:146:36