Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To fix React No Warnings & Prettified Test #2143

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Jun 4, 2024

Objective:

To fix React No Warnings & Prettified test

Issue:

yarn install v1.22.22
[1/4] Resolving packages...
warning Resolution field "formidable@3.5.1" is incompatible with requested version "formidable@^2.1.2"
error Invariant Violation: should have a resolved reference
    at invariant (/usr/local/lib/node_modules/yarn/lib/cli.js:2318:15)
    at PackageRequest.resolveToExistingVersion (/usr/local/lib/node_modules/yarn/lib/cli.js:36751:51)
    at PackageResolver.resolvePackagesWithExistingVersions (/usr/local/lib/node_modules/yarn/lib/cli.js:65397:13)
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
    at PackageResolver.<anonymous> (/usr/local/lib/node_modules/yarn/lib/cli.js:65253:12)
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Error: Process completed with exit code 1.

Solution:

To use version 9.0.2 of superagent as stated in https://www.npmjs.com/package/superagent#install

Not related to:

Test result:

Screenshot 2024-06-04 at 11 04 59 AM

@cniackz cniackz changed the title To fix js test issue [WIP] - To fix js test issue Jun 4, 2024
@cniackz cniackz changed the title [WIP] - To fix js test issue To fix React No Warnings & Prettified Test Jun 4, 2024
@cniackz cniackz self-assigned this Jun 4, 2024
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should upgrade operator also to Yarn 4.

@shtripat
Copy link
Contributor

shtripat commented Jun 4, 2024

LGTM. I think we should upgrade operator also to Yarn 4.

+1

@ramondeklein
Copy link
Contributor

LGTM. I think we should upgrade operator also to Yarn 4.

+1

See #2144

@pjuarezd pjuarezd merged commit 3cea44a into minio:master Jun 4, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants