Fix: use correct keyname to read the version from Manifest file

.github/workflows/gradle.yml

@@ -24,11 +24,20 @@ jobs:
         uses: actions/setup-java@v1
         with:
           java-version: ${{ matrix.java-version }}
+      - name: Set environment variables
+        run: |
+          echo "::set-env name=DEV_VERSION::$(./gradlew properties | awk '/^version:/ { print $2 }')"
+          echo "::set-env name=RELEASE_VERSION::$(./gradlew properties -Prelease | awk '/^version:/ { print $2 }')"
       - name: Gradle build on ${{ matrix.java-version }}
         if: matrix.os == 'ubuntu-latest'
         run: |
           ./gradlew build
           ./gradlew runFunctionalTest
+          javac -cp api/build/libs/minio-${DEV_VERSION}-all.jar functional/TestUserAgent.java
+          java -Dversion=${DEV_VERSION} -cp api/build/libs/minio-${DEV_VERSION}-all.jar:functional TestUserAgent
+          ./gradlew build -Prelease
+          javac -cp api/build/libs/minio-${RELEASE_VERSION}-all.jar functional/TestUserAgent.java
+          java -Dversion=${RELEASE_VERSION} -cp api/build/libs/minio-${RELEASE_VERSION}-all.jar:functional TestUserAgent
       - name: Gradle build on ${{ matrix.java-version }}
         if: matrix.os == 'windows-latest'
         run: |

api/src/main/java/io/minio/MinioProperties.java

@@ -65,7 +65,7 @@ private void setMinioClientJavaVersion(ClassLoader classLoader) throws IOExcepti
       while (resources.hasMoreElements()) {
         Manifest manifest = new Manifest(resources.nextElement().openStream());
         for (Object k : manifest.getMainAttributes().keySet()) {
-          String versionString = "MinIO-Client-Java-Version";
+          String versionString = "Implementation-Version";
           if (k.toString().equals(versionString)) {
             version.set(manifest.getMainAttributes().getValue((Attributes.Name) k));
           }

build.gradle

@@ -131,7 +131,7 @@ project(':api') {
         manifest {
             attributes('Implementation-Title': archivesBaseName,
             'Implementation-Version': version,
-            'Built-By': System.getProperty('user.name'),
+            'Built-By': 'MinIO, inc',
             'Built-JDK': System.getProperty('java.version'),
             'Source-Compatibility': sourceCompatibility,
             'Target-Compatibility': targetCompatibility)

functional/TestUserAgent.java

@@ -0,0 +1,49 @@
+/*
+ * MinIO Java SDK for Amazon S3 Compatible Cloud Storage,
+ * (C) 2020 MinIO, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import io.minio.BucketExistsArgs;
+import io.minio.MinioClient;
+import java.io.ByteArrayOutputStream;
+import java.nio.charset.StandardCharsets;
+import java.util.Scanner;
+
+public class TestUserAgent {
+  public static void main(String[] args) throws Exception {
+    MinioClient client = new MinioClient("http://example.org");
+    ByteArrayOutputStream baos = new ByteArrayOutputStream();
+    client.traceOn(baos);
+    client.bucketExists(BucketExistsArgs.builder().bucket("any-bucket-name-works").build());
+    client.traceOff();
+
+    String expectedVersion = System.getProperty("version");
+    String version = null;
+    try (Scanner scanner = new Scanner(new String(baos.toByteArray(), StandardCharsets.UTF_8))) {
+      while (scanner.hasNextLine()) {
+        String line = scanner.nextLine();
+        if (line.startsWith("User-Agent:")) {
+          version = line.split("/")[1];
+          break;
+        }
+      }
+    }
+
+    if (!expectedVersion.equals(version)) {
+      throw new Exception(
+          "version does not match; expected=" + expectedVersion + ", got=" + version);
+    }
+  }
+}