Few enhancements in the builder framework #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
requested review from
sinhaashish and
balamurugana
and removed request for
sinhaashish
anjalshireesh
force-pushed
the
builder-enhancements
branch
from
bbabfa5 to
2d08918
Compare
- Infer the type of the Args class by looking it up through reflection (`getEnclosingClass()`), so that there is no need for concrete builder classes to implement the `build()` method. - Change the generic type notations `<T, B>` to `<B, A>` to make them more intuitive (`B -> Builder` and `A -> Args`) - When inheriting from a parent builder class in an abstract builder class like `BucketArgs.Builder`, pass the type parameters of the current class (`<B, A>`) as is. This ensures that the builder methods, irrespective of what order they're called in, will always return an object with type of the original builder class.
anjalshireesh
force-pushed
the
builder-enhancements
branch
from
2d08918 to
18debd6
Compare
anjalshireesh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infer the type of the Args class by looking it up through reflection
(
getEnclosingClass()), so that there is no need for concrete builderclasses to implement the
build()method.Change the generic type notations
<T, B>to<B, A>to make themmore intuitive (
B -> BuilderandA -> Args)When inheriting from a parent builder class in an abstract builder
class like
BucketArgs.Builder, pass the type parameters of the currentclass (
<B, A>) as is. This ensures that the builder methods,irrespective of what order they're called in, will always return an
object with type of the original builder class.