Only retry multi-part upload as single-part upload on GCS endpoints #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Oct 21, 2024
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Jan 7, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/minio/minio-go/v7](https://github.com/minio/minio-go) | require | patch | `v7.0.78` -> `v7.0.83` | --- ### Release Notes <details> <summary>minio/minio-go (github.com/minio/minio-go/v7)</summary> ### [`v7.0.83`](minio/minio-go@v7.0.82...v7.0.83) [Compare Source](minio/minio-go@v7.0.82...v7.0.83) ### [`v7.0.82`](https://github.com/minio/minio-go/releases/tag/v7.0.82): Bugfix Release [Compare Source](minio/minio-go@v7.0.81...v7.0.82) #### What's Changed - sts: Send the refresh token in the login redirect URL by [@​vadmeste](https://github.com/vadmeste) in minio/minio-go#2025 - Fix duplicate API call on `obj.Stat()` by [@​OrkhanAlikhanov](https://github.com/OrkhanAlikhanov) in minio/minio-go#2028 - Fix for tests running in mint vs locally by [@​marktheunissen](https://github.com/marktheunissen) in minio/minio-go#2029 - Add Full Object Checksum API by [@​klauspost](https://github.com/klauspost) in minio/minio-go#2026 - Read ChecksumAlgorithm and ChecksumType from ListParts by [@​klauspost](https://github.com/klauspost) in minio/minio-go#2032 - Bump golang.org/x/crypto from 0.28.0 to 0.31.0 in /examples/s3 by [@​dependabot](https://github.com/dependabot) in minio/minio-go#2033 #### New Contributors - [@​OrkhanAlikhanov](https://github.com/OrkhanAlikhanov) made their first contribution in minio/minio-go#2028 **Full Changelog**: minio/minio-go@v7.0.81...v7.0.82 ### [`v7.0.81`](https://github.com/minio/minio-go/releases/tag/v7.0.81): Bugfix Release [Compare Source](minio/minio-go@v7.0.80...v7.0.81) #### What's Changed - PromptObject API support by [@​sidharthrajaram](https://github.com/sidharthrajaram) in minio/minio-go#2015 - Fix new lint errors by [@​klauspost](https://github.com/klauspost) in minio/minio-go#2020 - functional tests: move client creation into a reusable function by [@​marktheunissen](https://github.com/marktheunissen) in minio/minio-go#2022 - Adjust testPresignedPostPolicy to ensure that GetObject... by [@​marktheunissen](https://github.com/marktheunissen) in minio/minio-go#1996 - Add refresh token to WebIdentity OpenID response by [@​vadmeste](https://github.com/vadmeste) in minio/minio-go#2023 #### New Contributors - [@​sidharthrajaram](https://github.com/sidharthrajaram) made their first contribution in minio/minio-go#2015 **Full Changelog**: minio/minio-go@v7.0.80...v7.0.81 ### [`v7.0.80`](https://github.com/minio/minio-go/releases/tag/v7.0.80): Bugfix Release [Compare Source](minio/minio-go@v7.0.79...v7.0.80) #### What's Changed - Add support for AllVersionsExpiration ilm rule by [@​dhananjaykrutika](https://github.com/dhananjaykrutika) in minio/minio-go#2014 - retry: make max retries configurable by [@​ashwanthgoli](https://github.com/ashwanthgoli) in minio/minio-go#2013 #### New Contributors - [@​dhananjaykrutika](https://github.com/dhananjaykrutika) made their first contribution in minio/minio-go#2014 - [@​ashwanthgoli](https://github.com/ashwanthgoli) made their first contribution in minio/minio-go#2013 **Full Changelog**: minio/minio-go@v7.0.79...v7.0.80 ### [`v7.0.79`](https://github.com/minio/minio-go/releases/tag/v7.0.79): Bugfix Release [Compare Source](minio/minio-go@v7.0.78...v7.0.79) #### What's Changed - Update remove bucket replication reference by [@​emmanuel-ferdman](https://github.com/emmanuel-ferdman) in minio/minio-go#2006 - Only retry multi-part upload as single-part upload on GCS endpoints by [@​ramondeklein](https://github.com/ramondeklein) in minio/minio-go#2012 #### New Contributors - [@​emmanuel-ferdman](https://github.com/emmanuel-ferdman) made their first contribution in minio/minio-go#2006 **Full Changelog**: minio/minio-go@v7.0.78...v7.0.79 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTEuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19--> Co-authored-by: Gusted <postmaster@gusted.xyz> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6479 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org> Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of GCS compatibility, the multi-part upload retries a multi-part upload as a single
PutObjectwhen it receives an access denied. This introduces a strange error message, because when a multi-part upload isn't allowed (i.e. due to policy), then it retries the operation as a single-part operation.Single part uploads are limited to 5GiB, so if uploading a file larger than 5GiB is uploaded, but not allowed, this will return the following error message:
Your proposed upload size ‘...’ exceeds the maximum allowed object size ‘5368709120’ for single PUT operation.. For AWS S3 and MinIO, there is just a single action for upload operations (s3:PutObject), so it doesn't make sense to retry the upload. This saves a roundtrip and an error message that could be misleading.