Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication: additional fields for metrics #1874

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

poornas
Copy link
Contributor

@poornas poornas commented Aug 16, 2023

No description provided.

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we simply need to have some validation on the data structure received such that we can avoid panics at runtime.

Add some validation before we can trust the structs, return error early and then we can safely process the stats.

pkg/replication/replication.go Outdated Show resolved Hide resolved
@harshavardhana harshavardhana merged commit 1eac111 into minio:master Aug 21, 2023
7 checks passed
@jiuker
Copy link
Contributor

jiuker commented Aug 23, 2023

It broken something to mc. @poornas @harshavardhana

../../pkg/mc/cmd/replicate-status.go:94:25: s.ReplicationStatus.FailedSize undefined (type replication.Metrics has no field or method FailedSize)
../../pkg/mc/cmd/replicate-status.go:105:35: s.ReplicationStatus.FailedCount undefined (type replication.Metrics has no field or method FailedCount)
../../pkg/mc/cmd/replicate-status.go:106:35: s.ReplicationStatus.FailedSize undefined (type replication.Metrics has no field or method FailedSize)
../../pkg/mc/cmd/replicate-status.go:119:20: st.FailedCount undefined (type replication.TargetMetrics has no field or method FailedCount)
../../pkg/mc/cmd/replicate-status.go:120:19: st.FailedSize undefined (type replication.TargetMetrics has no field or method FailedSize)
../../pkg/mc/cmd/replicate-status.go:121:20: st.ReplicaSize undefined (type replication.TargetMetrics has no field or method ReplicaSize)
../../pkg/mc/cmd/replicate-status.go:173:71: st.FailedSize undefined (type replication.TargetMetrics has no field or method FailedSize)
../../pkg/mc/cmd/replicate-status.go:173:108: st.FailedCount undefined (type replication.TargetMetrics has no field or method FailedCount)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants