fix: handle Add event in node event listener #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonus: also fix the nil value while creating the node during refresh during `kubectl directpv discover` command
Praveenrajmani
force-pushed
the
fix-disc-add
branch
from
6bbbf03
to
c207476
Compare
balamurugana
changed the title
pjuarezd
previously approved these changes
Apr 23, 2024
Praveenrajmani
force-pushed
the
fix-disc-add
branch
from
c207476
to
ea6dbad
Compare
balamurugana
approved these changes
Apr 23, 2024
pjuarezd
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bonus: also fix the nil value while creating the node during refresh during
kubectl directpv discovercommandSteps to test
kubectl delete directpvnode <node-name>kubectl directpv discover