Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm chart for DirectPV operator #821

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Add Helm chart for DirectPV operator #821

merged 1 commit into from
Aug 16, 2023

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Aug 4, 2023

Objective:

Add Helm Chart for DirectPV

Reasoning:

This will be needed for our DirectPV Helm Operator that will be used for the certification. When initializing the Operator, we have a flag where this folder goes: --helm-chart then Operator will use that helm chart for reconciling.

Documentation:

@cniackz cniackz added the certification for any given certification label Aug 10, 2023
Praveenrajmani
Praveenrajmani previously approved these changes Aug 11, 2023
Copy link
Collaborator

@Praveenrajmani Praveenrajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we generate the manifests for the latest version (v4.0.7)?

LGTM otherwise

helm.sh Outdated Show resolved Hide resolved
helm/templates/CSIDriver.yaml Show resolved Hide resolved
balamurugana
balamurugana previously approved these changes Aug 11, 2023
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need to have configurable values for

  • Node selector
  • Tolerations
  • Apparmor profile
  • Seccomp profile
  • Image pull secrets
  • directpv image
  • csi-node-registrar image
  • csi-provisioner image
  • livenessprobe image
  • csi-resizer image
  • deployment selector value (for upgrade)
  • daemonset selector value (for upgrade)

This can be addressed in separate PRs

@balamurugana balamurugana changed the title Adding a Helm Chart of DirectPV for the Helm Operator Add Helm chart for DirectPV operator Aug 11, 2023
@cniackz cniackz mentioned this pull request Aug 15, 2023
@Praveenrajmani Praveenrajmani merged commit fdc576d into minio:master Aug 16, 2023
22 checks passed
@cniackz cniackz deleted the helm-operator-1 branch August 16, 2023 12:50
@pschichtel
Copy link

@cniackz where will the chart be published? minio's main repo?

@balamurugana
Copy link
Member

@pschichtel There is no plan to support this helm chart. We are primarily working on OpenShift certification for DirectPV and this chart is specifically for that.

@pschichtel
Copy link

@balamurugana

from a first glance there doesn't seem to be a reason this chart wouldn't also work on standard kubernetes. from a deployment automation standpoint a helm chart would be great to have.

is this more of a "it's not a priority for now" thing? and would PRs with chart changes be accepted?

@balamurugana
Copy link
Member

@pschichtel It works but it is not complete. I mentioned few in #821 (review). We welcome your PRs. Please feel free to send them.

Praveenrajmani added a commit that referenced this pull request Aug 29, 2023
### Objective:

To add `Helm Operator` for DirectPV

### Source:

* https://github.com/cniackz/directpv-helm-operator

### Testing Notes:

*
https://github.com/cniackz/public/wiki/How-to-test-DirectPV-Operator-%E2%80%90-2

### Needed:

* #821

Co-authored-by: Praveen raj Mani <praveen@minio.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
certification for any given certification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants