-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm chart for DirectPV operator #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we generate the manifests for the latest version (v4.0.7)?
LGTM otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to have configurable values for
- Node selector
- Tolerations
- Apparmor profile
- Seccomp profile
- Image pull secrets
- directpv image
- csi-node-registrar image
- csi-provisioner image
- livenessprobe image
- csi-resizer image
- deployment selector value (for upgrade)
- daemonset selector value (for upgrade)
This can be addressed in separate PRs
e924a4a
@cniackz where will the chart be published? minio's main repo? |
@pschichtel There is no plan to support this helm chart. We are primarily working on OpenShift certification for DirectPV and this chart is specifically for that. |
from a first glance there doesn't seem to be a reason this chart wouldn't also work on standard kubernetes. from a deployment automation standpoint a helm chart would be great to have. is this more of a "it's not a priority for now" thing? and would PRs with chart changes be accepted? |
@pschichtel It works but it is not complete. I mentioned few in #821 (review). We welcome your PRs. Please feel free to send them. |
### Objective: To add `Helm Operator` for DirectPV ### Source: * https://github.com/cniackz/directpv-helm-operator ### Testing Notes: * https://github.com/cniackz/public/wiki/How-to-test-DirectPV-Operator-%E2%80%90-2 ### Needed: * #821 Co-authored-by: Praveen raj Mani <praveen@minio.io>
Objective:
Add
Helm Chart
for DirectPVReasoning:
This will be needed for our DirectPV Helm Operator that will be used for the certification. When initializing the Operator, we have a flag where this folder goes:
--helm-chart
then Operator will use that helm chart for reconciling.Documentation:
Thank you @balamurugana for providing the notes and for finding this method!
https://github.com/cniackz/public/wiki/Helm-Operator-for-DirectPV