Improve UI for drive initialization and discovery commands #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveenrajmani
force-pushed
the
init-progress
branch
2 times, most recently
from
6b2d4a7
to
e2b98e6
Compare
Praveenrajmani
force-pushed
the
init-progress
branch
from
e2b98e6
to
6a9f7bd
Compare
balamurugana
reviewed
Feb 3, 2023
cmd/kubectl-directpv/init.go
Outdated
| var initRequestListTimeout = 2 * time.Minute | ||
| var ( | ||
| initRequestListTimeout = 2 * time.Minute | ||
| tick = "✔" |
|
will make some more improvements on the UI |
Praveenrajmani
force-pushed
the
init-progress
branch
from
aaef03f
to
181d6ec
Compare
Praveenrajmani
force-pushed
the
init-progress
branch
from
181d6ec
to
8d55037
Compare
Praveenrajmani
changed the title
balamurugana
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://asciinema.org/a/dWh5AysdtaZaS4pfRO3hYUuyt