Expose a NodePort service for the admin server by default #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveenrajmani
force-pushed
the
node-port-svc
branch
from
21eff83
to
042edab
Compare
Praveenrajmani
force-pushed
the
node-port-svc
branch
from
042edab
to
2233d26
Compare
|
Addressed the comments @balamurugana |
| @@ -129,7 +129,11 @@ function unexport_admin_server() { | |||
| } | |||
|
|
|||
| function add_drives() { | |||
| echo -e 'ALL\nALL\nYes\n' | ./kubectl-directpv format --api-server localhost:40443 --allowed --force | |||
| # Get the nodeport service url | |||
There was a problem hiding this comment.
remove function export_admin_server() and function unexport_admin_server()
functests/common.sh
Outdated
| echo -e 'ALL\nALL\nYes\n' | ./kubectl-directpv format --api-server localhost:40443 --allowed --force | ||
| # Get the nodeport service url | ||
| url=$(minikube service --namespace=directpv-min-io admin-service --url) | ||
| adminServer=${url#"http://"} |
functests/common.sh
Outdated
| url=$(minikube service --namespace=directpv-min-io admin-service --url) | ||
| adminServer=${url#"http://"} | ||
|
|
||
| echo -e 'ALL\nALL\nYes\n' | ./kubectl-directpv format --admin-server "$adminServer" --allowed --force |
Praveenrajmani
force-pushed
the
node-port-svc
branch
from
2233d26
to
90231d6
Compare
balamurugana
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.