Add volume commands #645
Merged
Add volume commands #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
add-volume-commands
branch
4 times, most recently
from
756bae2
to
10fa6be
Compare
Signed-off-by: Bala.FA <bala@minio.io>
balamurugana
force-pushed
the
add-volume-commands
branch
from
10fa6be
to
a7823bc
Compare
Praveenrajmani
approved these changes
Sep 27, 2022
Comment on lines
+80
to
+98
| func getDriveSelectors() ([]types.LabelValue, error) { | ||
| var values []string | ||
| for i := range driveArgs { | ||
| if utils.TrimDevPrefix(driveArgs[i]) == "" { | ||
| return nil, fmt.Errorf("empty device name %v", driveArgs[i]) | ||
| } | ||
| values = append(values, utils.TrimDevPrefix(driveArgs[i])) | ||
| } | ||
| return getSelectorValues(values) | ||
| } | ||
|
|
||
| func getNodeSelectors() ([]types.LabelValue, error) { | ||
| for i := range nodeArgs { | ||
| if utils.TrimDevPrefix(nodeArgs[i]) == "" { | ||
| return nil, fmt.Errorf("empty node name %v", nodeArgs[i]) | ||
| } | ||
| } | ||
| return getSelectorValues(nodeArgs) | ||
| } |
There was a problem hiding this comment.
can these functions move to common utils.go file as it can be used for drive listing as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.