Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support virtual disks with no immutable/hardware persistent properties in them #580

Closed
Praveenrajmani opened this issue May 10, 2022 · 0 comments · Fixed by #613
Closed

Support virtual disks with no immutable/hardware persistent properties in them #580

Praveenrajmani opened this issue May 10, 2022 · 0 comments · Fixed by #613
Labels
good first issue Good for newcomers low-priority Low priority issues

Comments

@Praveenrajmani
Copy link
Collaborator

Praveenrajmani commented May 10, 2022 •
edited
Loading

The drive matching mechanism in directpv is based on immutable/hardware persistent properties like wwid, serialno etc and mutable/software properties like fsuuid, mduuid etc. The immutable property match is considered to be a "conclusive" match and the mutable property match is just a "considered" match.

Currently, for fresh installations on a setup with virtual disks (with zero h/w immutable properties), directpv couldn't make a conclusive match and couldn't create the drive CRD objects for all the drives.

possible solution :

  • Configuring the VM to assign unique properties like WWID, SerialNumber to the virtual disks
  • Provide support in directpv - for fresh installations (no remote drives present), skip matching and create drive objects for the initial discovery before starting the uevent listener and syncing.
@Praveenrajmani Praveenrajmani added good first issue Good for newcomers low-priority Low priority issues labels May 10, 2022
@Praveenrajmani Praveenrajmani mentioned this issue May 10, 2022
Closed
@Praveenrajmani Praveenrajmani mentioned this issue May 23, 2022
Closed
@x3nb63 x3nb63 mentioned this issue Jun 8, 2022
Closed
Praveenrajmani added a commit to Praveenrajmani/directpv that referenced this issue Jul 21, 2022
@Praveenrajmani
Support virtual disks by relaxing the hashed uuid generation for the …
f53403d 
…drive names

currently, the name of the newly created drive is a uuid which will be calculated by
the hash of the hardware persistent properties of the drive. This prevents creation of
any virtual disks which will not have any ids on them.

by assigning random uuids for the drive names, we acccept such virtual disks

Fixes minio#580
@Praveenrajmani Praveenrajmani mentioned this issue Jul 21, 2022
Merged
harshavardhana pushed a commit that referenced this issue Jul 21, 2022
@Praveenrajmani
Support virtual disks by relaxing the hashed uuid generation for the …
e17dd82 
…drive names (#613)

currently, the name of the newly created 
drive is a uuid which will be calculated by
the hash of the hardware persistent properties 
of the drive. This prevents creation of
any virtual disks which will not have any 
ids on them.

by assigning random uuids for the drive 
names, we acccept such virtual disks

Fixes #580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low-priority Low priority issues
Projects
None yet
Milestone
No milestone
1 participant
@Praveenrajmani