Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User session fixes #3397

Merged
merged 4 commits into from
Jul 5, 2024
Merged

User session fixes #3397

merged 4 commits into from
Jul 5, 2024

Conversation

ramondeklein
Copy link
Collaborator

@ramondeklein ramondeklein commented Jul 4, 2024 •
edited
Loading

This fixes:

  • Incorrect comment about S3 authentication type.
  • Remove unused unmarshal/marshal of policy.
  • Remove unused verify methods for parsing token (without verification).

@ramondeklein ramondeklein self-assigned this Jul 4, 2024
@ramondeklein ramondeklein marked this pull request as ready for review July 4, 2024 09:54
@ramondeklein
Copy link
Collaborator Author

Vulnerability check should pass after PR #3398 has been merged.

@ramondeklein
Copy link
Collaborator Author

I'm not authorized to merge this. @harshavardhana Can you merge?

@harshavardhana harshavardhana merged commit 13d83a6 into minio:master Jul 5, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@reivaj05 reivaj05 reivaj05 approved these changes

@bayasdev bayasdev bayasdev approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

Assignees

@ramondeklein ramondeklein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramondeklein @harshavardhana @reivaj05 @bayasdev