Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated react-pdf dependency #3342

Merged
merged 1 commit into from
May 10, 2024
Merged

Updated react-pdf dependency #3342

merged 1 commit into from
May 10, 2024

Conversation

bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented May 10, 2024

What does this do?

Updated react-pdf dependency as mentioned in wojtekmaj/react-pdf#1786

According this document audit alert will still appear until mozilla/pdf.js#18051 gets merged & applied to react-pdf library. In the meantime the issue cannot be exploited as react-pdf in their latest version enforced the use of isEvalSupported function to false.

bayasdev
bayasdev previously approved these changes May 10, 2024
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@prakashsvmx
Copy link
Member

@bexsoft looks like it is failing in CI
yarn audit v1.22.22
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ high │ PDF.js vulnerable to arbitrary JavaScript execution upon │
│ │ opening a malicious PDF │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ pdfjs-dist │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=4.2.67 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ react-pdf │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ react-pdf > pdfjs-dist │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://www.npmjs.com/advisories/1097244
└───────────────┴──────────────────────────────────────────────────────────────┘
1 vulnerabilities found - Packages audited: 540

@bexsoft
Copy link
Collaborator Author

bexsoft commented May 10, 2024

@bexsoft looks like it is failing in CI yarn audit v1.22.22 ┌───────────────┬──────────────────────────────────────────────────────────────┐ │ high │ PDF.js vulnerable to arbitrary JavaScript execution upon │ │ │ opening a malicious PDF │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Package │ pdfjs-dist │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Patched in │ >=4.2.67 │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Dependency of │ react-pdf │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Path │ react-pdf > pdfjs-dist │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ More info │ https://www.npmjs.com/advisories/1097244 │ └───────────────┴──────────────────────────────────────────────────────────────┘ 1 vulnerabilities found - Packages audited: 540

Yes @prakashsvmx This is expected according wojtekmaj/react-pdf#1786, this updated react-pdf version avoids the exploit of this issue according to the creator of the library

@bexsoft bexsoft merged commit 9e0a020 into minio:master May 10, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants