Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] set up tsconfig for tests, write first test for validate config (Happy flow) #46

Merged
merged 4 commits into from
Jan 10, 2021

Conversation

yaka-fi2c
Copy link
Contributor

@yaka-fi2c yaka-fi2c commented Jan 3, 2021

  • support tsconfig file for tests
  • write small test for validate config

@SnirShechter need help on being able to import files on AVA test file (e.g import {myProp} from 'myfile.js' its not accepting it with .js

tbd -> fix the file so will be able to import with .js inside AVA

@yaka-fi2c yaka-fi2c added help wanted Extra attention is needed WIP This is not yet ready labels Jan 3, 2021
@SnirShechter
Copy link
Member

Ava does not yet support ESM. There's an open issue hanging for more than a year and a project with multiple tickets.

I suggest doing one of three options:

  • Checking out their progress and possibly find a way we can use esm (seems like they support .mjs, for example).
  • Patching up ava (first by ourselves manually in the node_modules, recorded by patch-package, and then submit a PR.
  • Switch to a different testing framework

@SnirShechter SnirShechter merged commit 67584de into main Jan 10, 2021
@SnirShechter SnirShechter deleted the feature/add-test-to-validate-func branch January 10, 2021 21:47
github-actions bot pushed a commit that referenced this pull request Jan 10, 2021
…to-validate-func

[WIP] set up tsconfig for tests, write first test for validate config (Happy flow)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed WIP This is not yet ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants