Update options page definition in extension manifest

mingyaulee · Jun 14, 2021 · 5600049 · 5600049
1 parent 41b6933
commit 5600049
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -146,7 +146,10 @@ Add a `Popup.razor` Razor component under `Pages` folder with the following cont
 ### Add an extension options page
 Add the following to the `manifest.json`
 ```json
-"options_page": "index.html?path=options"
+"options_ui": {
+  "page": "index.html?path=options",
+  "open_in_tab": true
+}
 ```
 Add a `Options.razor` Razor component under `Pages` folder with the following content.
 ```razor

diff --git a/src/Blazor.BrowserExtension.Build/Tasks/ExtensionManifest/ManifestItemKey.cs b/src/Blazor.BrowserExtension.Build/Tasks/ExtensionManifest/ManifestItemKey.cs
@@ -3,7 +3,7 @@
     internal enum ManifestItemKey
     {
         ManifestVersion,
-        OptionsPage,
+        OptionsUi,
         BrowserAction,
         Background,
         ContentSecurityPolicy,

diff --git a/src/Blazor.BrowserExtension.Build/Tasks/ExtensionManifest/ManifestParser.cs b/src/Blazor.BrowserExtension.Build/Tasks/ExtensionManifest/ManifestParser.cs
@@ -61,7 +61,7 @@ private static bool TryParseManifestItemKey(string line, out ManifestItemKey? ma
             return key switch
             {
                 "manifest_version" => ManifestItemKey.ManifestVersion,
-                "options_page" => ManifestItemKey.OptionsPage,
+                "options_ui" => ManifestItemKey.OptionsUi,
                 "browser_action" => ManifestItemKey.BrowserAction,
                 "background" => ManifestItemKey.Background,
                 "content_security_policy" => ManifestItemKey.ContentSecurityPolicy,

diff --git a/src/Blazor.BrowserExtension.Template/HelloBlazorExtension/wwwroot/manifest.json b/src/Blazor.BrowserExtension.Template/HelloBlazorExtension/wwwroot/manifest.json
@@ -18,7 +18,10 @@
     "webRequest",
     "webRequestBlocking"
   ],
-  "options_page": "index.html?path=options",
+  "options_ui": {
+    "page": "index.html?path=options",
+    "open_in_tab": true
+  },
   "browser_action": {
     "default_popup": "index.html?path=popup"
   }

diff --git a/test/Blazor.BrowserExtension.IntegrationTest/wwwroot/manifest.json b/test/Blazor.BrowserExtension.IntegrationTest/wwwroot/manifest.json
@@ -10,7 +10,10 @@
   "browser_action": {
     "default_popup": "index.html?path=popup"
   },
-  "options_page": "index.html?path=options",
+  "options_ui": {
+    "page": "index.html?path=options",
+    "open_in_tab": true
+  },
   "content_scripts": [
     {
       "matches": [ "*://*/*" ],