feat: introduce Node as Cluster #823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/givanovexpe/diagrams into givanovexpe-feature/add_icons_to_cluster_labels
…0-279-branded-clusters
Node as cluster
|
@mingrammer any chance of getting this in? A lot of work and time was put in #438 and that was not merged because too much time passed and the original author was (rightly) unwilling to resolve conflicts after such a long time. Would be a shame to let the same thing happen here |
|
Please check the tests. |
|
@lazzurs Hey Rob, do you think you could check if yo could fix-up the code to let the tests pass? Seems like @mingrammer doesn't mind merging as long as the tests are green? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to replace #438 to fix up the merge conflicts. Most of the work has been done by others but I am willing to address any comments in this PR and keep it up to date to get it merged.
Not tested as #799 needs merged too.