Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Legacy ENV Path #1008

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Updated Legacy ENV Path #1008

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c061290
Minor Change
0xAJX Jul 21, 2024
11a92b6
fix: pin python version + fix font path
gabriel-tessier Oct 20, 2024
b1edfbe
More recent Python version
gabriel-tessier Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docker/dev/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# use latest python 3 alpine image.
FROM python:3-alpine
# use latest python alpine image.
FROM python:3.12.6-alpine3.20

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://hub.docker.com/layers/library/python/3.12.7-alpine/images/sha256-f498302457ec11162f872199b92239c34e1fbcdbc391ff37a4959e820224aa98?context=explore
i think we should use python:3.12.7-alpine

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvqphuoc01
Thanks for the check,
I hope it will be quickly merged before a new version release.

# install system dependencies.
RUN apk update && apk add --no-cache \
Expand All @@ -9,14 +9,14 @@ RUN apk update && apk add --no-cache \
RUN go install github.com/mingrammer/round@latest

# install fonts
RUN curl -O https://noto-website.storage.googleapis.com/pkgs/NotoSansCJKjp-hinted.zip \
RUN curl -O https://noto-website-2.storage.googleapis.com/pkgs/NotoSansCJKjp-hinted.zip \
&& mkdir -p /usr/share/fonts/NotoSansCJKjp \
&& unzip NotoSansCJKjp-hinted.zip -d /usr/share/fonts/NotoSansCJKjp/ \
&& rm NotoSansCJKjp-hinted.zip \
&& fc-cache -fv

# add go bin to path.
ENV PATH "$PATH:/root/go/bin"
ENV PATH="$PATH:/root/go/bin"

# project directory.
WORKDIR /usr/src/diagrams
Expand All @@ -25,4 +25,4 @@ WORKDIR /usr/src/diagrams
COPY . .

# install python requirements.
RUN pip install black graphviz jinja2
RUN pip install black graphviz jinja2
Loading