This repository has been archived by the owner on May 13, 2024. It is now read-only.
Set policies through version 3.9 to allow better IPO support #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OLD behavior of a CMake policy is deprecated by default, so a version range can be used to set all policies to NEW on the appropriate versions. It is difficult to test this extensively, but it is unlikely to cause a problem, and could fix some bugs for people using newer versions. I picked 3.9 as the top of the version range to minimize the effects, because 3.9 will set CMP0069 to NEW, which is the focus of this commit.
|
|
sfan5
approved these changes
Aug 21, 2021
There was a problem hiding this comment.
The min...max syntax was only added in CMake 3.12 so it'll only work there but fine by me.
|
There's a way to set up policies on older versions (< 3.12) also, but I hadn't considered it. I could add that if necessary; I don't know how many people would need it. |
|
@sfan5 fmtlib/fmt#809 Does this apply to us? I'm trying to figure out what's the point of using a version range at all when a conditional block works for all versions to set policies and I noticed this. |
|
I don't think so. |
The version range that was previously introduced has two drawbacks: it has no effect prior to version 3.12, and on older MSVC versions there is a bug that causes it to error. The conditional block solves both of this issues.
|
Changed it anyway because I see only pros. |
sfan5
reviewed
Aug 21, 2021
JosiahWI
changed the title
JosiahWI
changed the title
sfan5
reviewed
Aug 21, 2021
Co-authored-by: sfan5 <sfan5@live.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OLD behavior of a CMake policy is deprecated by default, so a version range can be used to set all policies to NEW on the appropriate versions. It is difficult to test this extensively, but it is unlikely to cause a problem, and could fix some bugs for people using newer versions. I picked 3.9 as the top of the version range to minimize the effects, because 3.9 will set CMP0069 to NEW, which is the focus of this commit.
If a version is newer than the top of the range, its policies will be set based on the highest version in the range.
Fixes #54.