Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Commit

Permalink
Update workflow to address deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
@sfan5
sfan5 committed Dec 31, 2022
1 parent 2ae816b commit ce0d29d
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
image: ubuntu:bionic
env: { LANG: "C.UTF-8" }
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install deps
run: |
apt-get update
Expand All @@ -40,7 +40,7 @@ jobs:
image: ubuntu:bionic
env: { LANG: "C.UTF-8" }
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install deps
run: |
apt-get update
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
image: ubuntu:jammy
env: { LANG: "C.UTF-8" }
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install deps
run: |
apt-get update
Expand All @@ -89,7 +89,7 @@ jobs:
win32:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install compiler
run: |
sudo apt-get update && sudo apt-get install cmake -qyy
Expand All @@ -111,7 +111,7 @@ jobs:
win64:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install compiler
run: |
sudo apt-get update && sudo apt-get install cmake -qyy
Expand All @@ -131,9 +131,9 @@ jobs:
path: ./irrlicht-win64.zip

macos:
runs-on: macos-10.15
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install deps
run: |
brew update
Expand Down Expand Up @@ -202,7 +202,7 @@ jobs:
run: move include artifact/

- name: Upload Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: msvc-${{ matrix.config.arch }}
path: artifact/

4 comments on commit ce0d29d

@Zweihorn
Copy link

@Zweihorn Zweihorn commented on ce0d29d Jan 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and good to know. I will try this with the "minetest" port at MacPorts soon.

@sfan5 - However, would you be able to help with this issue of a poor old legacy macOS platform called Mac OS X 10.6 Snow Leopard and OpenGL please?

Don't want to bother you, however, you don't ask, you don't get, they say.

@rubenwardy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely not the right place to raise this, better to make an issue.

Also, it might be easier to build irrlichtmt into Minetest rather than having an irrlichtmt port. Cloning irrlicht into libs/irrlichtmt will cause mt to statically link automatically

@Zweihorn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely not the right place to raise this, better to make an issue.

Also, it might be easier to build irrlichtmt into Minetest rather than having an irrlichtmt port. Cloning irrlicht into libs/irrlichtmt will cause mt to statically link automatically

THX

  • Good point. My fire and forget approach will be improved by a more applicable issue.
  • At MacPorts the "irrlichtmt " port is long standing and integrates very well into the "minetest" port as dependency.
  • The one liner sudo port install minetest will just install both and more ports seamlessly.

However, will definitely elaborate outside this thread as was proposed.

@Zweihorn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#152

Please sign in to comment.