-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PXP-477: [CLI] Develop the config secrets push command #81
Conversation
can you update the completions by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see, this command allows to select an individual change in a secret file to apply the edit. This is similar to Git diff, however I'm wonder if we have actual case for this.
From the user's perspective, the diff merely for me to review the change, and I can either accept or deny it, plus an option to go back and making some edits. Selecting individual changes seems not practical IMHO.
Also, I don't see we're handling the case of multiple annotations. For example if there is an umbrella Elixir application, there can be more than 1 annotations, thus leading to multiple secret files . I just need the confirmation that we're not handling this case atm, to determine what would be the next step.
I see, so the command is meant to be used with the annotation? The RFC I saw was saying "Pull the secret file from Bunker, make changes, and push new contents to update the Bunker". I think we misunderstood that. |
2ad3b8a
to
6a5a7ff
Compare
12fff38
to
b1d8f6a
Compare
For this error.
We should add a suggestion text to ask user maybe they will need to run the |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mfauzaan, onimsha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
since the possibility of this is small atm, we can address this in another PR later.
Summary
This PR adds a bunker secret edit command to the Wukong CLI, enabling users to update remote secrets via the command line interface after making changes to the local config files.
Example command usage:
wukong-cli dev config push {path}
Multiple config changes:

Diff with the changes:

Ticket: PXP-477
What's Changed
Added