Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup dependencies and use workspace dependencies for share … #210

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

jk-gan
Copy link
Contributor

@jk-gan jk-gan commented Mar 18, 2024

…deps

Summary

I do a cleanup for the dependencies. Move all the shared dependencies into workspace, and remove a lot of unused dependencies.

Ticket:

What's Changed

Changed

  • move shared dependencies into workspace dependencies

Fixed

  • Fixed some CVE by removing unused dependencies

@jk-gan jk-gan requested review from mfauzaan, onimsha and Fadhil March 18, 2024 09:12
@jk-gan jk-gan self-assigned this Mar 18, 2024
@jk-gan jk-gan added the enhancement New feature or request label Mar 18, 2024
mfauzaan
mfauzaan previously approved these changes Mar 18, 2024
@sauron-droid
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jk-gan, mfauzaan

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jk-gan jk-gan merged commit 93babfa into main Mar 19, 2024
5 checks passed
@sauron-droid sauron-droid deleted the chore/workspace-deps branch March 19, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XXL
Development

Successfully merging this pull request may close these issues.

3 participants