Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PXP-678: [CLI] Integrate application init name validation #205

Merged
merged 11 commits into from
Mar 14, 2024
Merged

PXP-678: [CLI] Integrate application init name validation #205

merged 11 commits into from
Mar 14, 2024
+1,817 −430

Conversation

mfauzaan
Copy link
Member

@mfauzaan mfauzaan commented Mar 11, 2024 •
edited
Loading

Summary

During the initialisation of the application init, Validate the name against the API to make sure the application name is unique across all the registered application.

Ticket: https://mindvalley.atlassian.net/browse/PXP-678

What's Changed

  • Add an api call after user input the value and validate agains the API and prompt an error if application exist

@mfauzaan mfauzaan self-assigned this Mar 11, 2024
@mfauzaan mfauzaan added the feature New feature label Mar 11, 2024
@mfauzaan mfauzaan requested review from Fadhil, jk-gan and onimsha March 11, 2024 08:36
jk-gan
jk-gan previously approved these changes Mar 12, 2024
View reviewed changes
onimsha
onimsha previously approved these changes Mar 14, 2024
View reviewed changes
@onimsha
Update generated code from googleapis
78e4a49 
Signed-off-by: Alex Co <alex.tuan@mindvalley.com>
@onimsha onimsha dismissed stale reviews from jk-gan and themself via 78e4a49 March 14, 2024 03:45
@onimsha onimsha merged commit c1faf94 into main Mar 14, 2024
5 checks passed
@sauron-droid
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mfauzaan, onimsha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sauron-droid sauron-droid deleted the feat/application-init-name-validation branch March 14, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onimsha onimsha onimsha approved these changes

@jk-gan jk-gan jk-gan left review comments

@Fadhil Fadhil Awaiting requested review from Fadhil

Assignees

@mfauzaan mfauzaan

Labels
feature New feature size/XXL
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfauzaan @sauron-droid @onimsha @jk-gan