-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PXP-670: [CLI] Implement the AppSignal integration to the deployment status command #198
Conversation
@jk-gan I got this error while trying to test the feature I understand this PR does not cover the init logic, but I wonder how did you test it ? |
I know how to get past this error. Now I got this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two major takeaways from this PR:
- The CLI is still expecting the config
application_name
in the global config. We will need to modify it to use the application config exclusively. - The CLI is possibly giving wrong data from AppSignal. The output is not matching with the mockup and the magic link is pointing to some
Unknown deployment
in AppSignal.
We will need to fix these issues before merging this PR.
AppSignal doesn't recognize the latest deploy marker from the url param, so I will use |
@jk-gan can you match the actual UI with the mockup as closet possible ? At least I want to see the For the |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jk-gan, onimsha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
The PR also include the error handling when the application config is not enabled or when the appsignal integration is not enabled.


Ticket: PXP-670
What's Changed
Added
wukong deployment status
commandFixed
Changed
.wukong.toml
file