Fix/handle broken google cloud welcome screen on tui #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk-gan
approved these changes
Feb 20, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jk-gan, mfauzaan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sauron-droid
deleted the
fix/handle-broken-google-cloud-welcome-screen-on-tui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor Welcome screen on the TUI to resolve issues with Google Auth initiation. The update separates the Google Cloud login logic from the core function, preventing conflicts and ensuring smooth execution of TUI with Google Auth.
Ticket: -
What's Changed
Changed
wukong init