-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PXP-638: [CLI] Implement new config #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. This looks good to go. We're mostly refactoring some config vars to use the new format with an auth
section. Let's test it out.
As I know, |
Yeah I think it's the right approach. Because when a user re-init the config, at the end of the initialisation process, they will have to review the config before writing it to disk, so it wouldn't make sense if we keep some of the old configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mfauzaan, onimsha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Build the workflow for the wukong init command to satisfy the specifications. Details about the command inputs and outputs can be found here.
Ticket: https://mindvalley.atlassian.net/browse/PXP-524
What's Changed
wukong init
wukong init
to avoid duplicate codes