PXP-628: [CLI]: Display new release info banner #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk-gan
requested changes
Nov 2, 2023
|
What is the UX you want to bring to the users? do we want to show error if there is an error occur during the update check? or we kinda make this invisible, the users don't have to know the update check error? If there is a new version release within 1 week since last update check, do we show the new version message? |
jk-gan
requested changes
Nov 2, 2023
jk-gan
requested changes
Nov 3, 2023
jk-gan
previously approved these changes
Nov 6, 2023
onimsha
reviewed
Nov 6, 2023
onimsha
previously approved these changes
Nov 6, 2023
onimsha
approved these changes
Nov 6, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mfauzaan, onimsha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To let developer know that there’s a new Wukong CLI version, we should display the notification in the terminal whenever user trigger the CLI.
To avoid spam, we should only display this maximum every 24hours
Ticket: https://mindvalley.atlassian.net/browse/PXP-624
What's Changed