Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXP-627: [CLI] Key binding is incorrect for the logs panel #157

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

jk-gan
Copy link
Contributor

@jk-gan jk-gan commented Oct 17, 2023

Summary

Previously the user is not able to close filter bar and search bar with Esc key. This PR fixes it.

Ticket: PXP-627

What's Changed

Fixed

  • Close filter bar and search bar with Esc key

@jk-gan jk-gan requested review from mfauzaan, Fadhil and onimsha October 17, 2023 08:47
@jk-gan jk-gan self-assigned this Oct 18, 2023
@jk-gan jk-gan added bug Something isn't working bugfix Bug fix labels Oct 18, 2023
@sauron-droid
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jk-gan, onimsha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onimsha onimsha merged commit dbeb4f5 into main Oct 19, 2023
@sauron-droid sauron-droid deleted the fix/keybinding branch October 19, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bugfix Bug fix size/M
Development

Successfully merging this pull request may close these issues.

3 participants