Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PXP-578: [CLI] Implement the headers section #131

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

jk-gan
Copy link
Contributor

@jk-gan jk-gan commented Aug 13, 2023

Summary

Spent quite some times to study the docs and other tui product, finally understand how the tui works. This PR is only for the header layout as the shortcut key implementation is on a separated ticket.

Ticket: PXP-578

What's Changed

Added

  • Implement header layout
Screenshot 2023-08-13 at 5 05 50 PM

@jk-gan jk-gan requested review from Fadhil, onimsha and mfauzaan August 13, 2023 09:06
@jk-gan jk-gan self-assigned this Aug 13, 2023
@jk-gan jk-gan added the feature New feature label Aug 13, 2023
@onimsha onimsha merged commit dd74bd9 into main Aug 14, 2023
@sauron-droid
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jk-gan, onimsha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sauron-droid sauron-droid deleted the feat/tui-header branch August 14, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants