add SVD training support #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadipash
commented
Mar 7, 2024
| if self.keep_loss_fp32: | ||
| pred = ops.cast(pred, ms.float32) | ||
| target = ops.cast(target, ms.float32) | ||
| dtype = pred.dtype |
There was a problem hiding this comment.
@zhanghuiyao is this what you originally intended to do?
zhtmike
reviewed
Mar 8, 2024
examples/stable_diffusion_xl/gm/modules/diffusionmodules/guiders.py
Outdated
Show resolved
Hide resolved
examples/stable_diffusion_xl/gm/modules/diffusionmodules/sigma_sampling.py
Outdated
Show resolved
Hide resolved
zhtmike
approved these changes
Mar 8, 2024
SamitHuang
reviewed
Mar 12, 2024
# Conflicts: # examples/stable_diffusion_xl/gm/modules/diffusionmodules/sigma_sampling.py
SamitHuang
approved these changes
Mar 19, 2024
|
@zhanghuiyao Please check whether these changes will impact SDXL training. |
CaitinZhao
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces support for SVD training, which is currently limited to 4 frames. Support for model parallel training with a higher number of frames will be added in a future PR.
Before submitting
What's New. Here are thedocumentation guidelines
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@xxx