-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a Slack Community badge #936
Conversation
Codecov Report
@@ Coverage Diff @@
## main #936 +/- ##
==========================================
+ Coverage 94.71% 94.72% +0.01%
==========================================
Files 134 134
Lines 5501 5501
==========================================
+ Hits 5210 5211 +1
+ Misses 291 290 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks @fharper really good idea :) |
I was thinking about reorganizing the icons as well ! For the sake of visual aspect, I'd suggest to go for a color matching Slack company guidelines while staying similar to other icons from the README. Something like this for instance ? Also I think there is a mistake in the slack URL you put (it looks like the internal one, not the community), I put the invitation URL in the above button ☝️ |
@frgfm: the link is good, and I prefer the one you created (the flat design) but it won't match with the other one. I guess you'll update them like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I hadn't checked that there is a redirect in the URL 👍
We'll update badges on another PR, that one is a great addition anyway !
Feel free to suggest the text, color or position changes!