Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Slack Community badge #936

Merged
merged 2 commits into from
Jun 1, 2022
Merged

add a Slack Community badge #936

merged 2 commits into from
Jun 1, 2022

Conversation

fharper
Copy link
Contributor

@fharper fharper commented May 31, 2022

Feel free to suggest the text, color or position changes!

@fharper fharper added the type: misc Miscellaneous label May 31, 2022
@fharper fharper self-assigned this May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #936 (49aa0a7) into main (75531c5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #936      +/-   ##
==========================================
+ Coverage   94.71%   94.72%   +0.01%     
==========================================
  Files         134      134              
  Lines        5501     5501              
==========================================
+ Hits         5210     5211       +1     
+ Misses        291      290       -1     
Flag Coverage Δ
unittests 94.72% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/functional/base.py 97.10% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75531c5...49aa0a7. Read the comment docs.

@felixdittrich92
Copy link
Contributor

Thanks @fharper really good idea :)
I would add it at least so it's more in focus @frgfm @charlesmindee wdyt ?

@frgfm
Copy link
Collaborator

frgfm commented Jun 1, 2022

I was thinking about reorganizing the icons as well !
Excellent idea @fharper 👍

For the sake of visual aspect, I'd suggest to go for a color matching Slack company guidelines while staying similar to other icons from the README. Something like this for instance ?
Docker

Also I think there is a mistake in the slack URL you put (it looks like the internal one, not the community), I put the invitation URL in the above button ☝️

@fharper
Copy link
Contributor Author

fharper commented Jun 1, 2022

@frgfm: the link is good, and I prefer the one you created (the flat design) but it won't match with the other one. I guess you'll update them like this?

Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I hadn't checked that there is a redirect in the URL 👍
We'll update badges on another PR, that one is a great addition anyway !

@frgfm frgfm added topic: documentation Improvements or additions to documentation type: new feature New feature and removed type: misc Miscellaneous labels Jun 1, 2022
@frgfm frgfm added this to the 0.6.0 milestone Jun 1, 2022
@frgfm frgfm merged commit f0337d1 into main Jun 1, 2022
@frgfm frgfm deleted the fharper/slack branch June 1, 2022 18:11
@frgfm frgfm mentioned this pull request Jun 28, 2022
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants