-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improved error message of encode_string #929
Conversation
FYI, there is already a test checking that this case throws a ValueError (and I don't think we need to check the error message additionally 😅 ) |
Codecov Report
@@ Coverage Diff @@
## main #929 +/- ##
==========================================
- Coverage 94.71% 94.70% -0.02%
==========================================
Files 134 134
Lines 5488 5491 +3
==========================================
+ Hits 5198 5200 +2
- Misses 290 291 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@frgfm |
Yes I hesitated, but I figured no one had shown interest initially, but I'll keep that in mind next time 👍 Actually @fharper, I've seen a few OSS libraries keeping a few issues on the side for newcomers, and posting it on social media (and they got new contributors with that). That could be an idea 🤷 |
Let's move the discussion on Slack, so we don't spam people here. |
This PR improves the error message of
encode_string
when a character is not to be found in the vocab.Closes #927
Any feedback is welcome!