-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[documentation/Fix] add documentation for huggingface feature and fix ocr_predictor model loading #896
Conversation
Codecov Report
@@ Coverage Diff @@
## main #896 +/- ##
=======================================
Coverage 94.69% 94.70%
=======================================
Files 133 133
Lines 5377 5387 +10
=======================================
+ Hits 5092 5102 +10
Misses 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that, waiting for @fharper to review the doc part!
is the "TODO: rework text in documentation" OK ? |
As mentioned to @felixdittrich92, I'll review today or worse case tomorrow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content LGTM (I wasn't able to generate the doc caused I still have issues on my M1 even following the steps from someone else)
@charlesmindee: can you validate and update the labels please. |
This PR:
adds documentation how to use the huggingface integration (load / push)
add tables for community models
fix for passing a model itself directly to the predictor
Issue:
#426 (can be closed after merge)
Review:
Code: @charlesmindee
Documentation: @fharper
Any feedback is welcome :)