Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Czech to the set of vocabularies in datasets/vocabs.py #885

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

Xargonus
Copy link
Contributor

@Xargonus Xargonus commented Apr 5, 2022

No description provided.

@charlesmindee
Copy link
Collaborator

Hi @Xargonus, just need to resolve conflicts with the main branch but otherwise it seems perfect!

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #885 (35750df) into main (2c697ff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #885   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files         133      133           
  Lines        5280     5281    +1     
=======================================
+ Hits         5012     5013    +1     
  Misses        268      268           
Flag Coverage Δ
unittests 94.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/datasets/vocabs.py 100.00% <100.00%> (ø)
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c697ff...35750df. Read the comment docs.

Copy link
Contributor

@fharper fharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm basing my review on @charlesmindee's comment, so let me know if I shouldn't have merge it :D

@fharper fharper merged commit b85d8c8 into mindee:main Apr 8, 2022
@fharper
Copy link
Contributor

fharper commented Apr 8, 2022

Thanks for the PR @Xargonus!

@fharper fharper added the type: enhancement Improvement label Apr 8, 2022
@frgfm
Copy link
Collaborator

frgfm commented Apr 27, 2022

Hey @fharper :)
The release note is automatically generated on this repo, but it requires specific combinations of tags, namely one "type" and one "module" or "ext" (to have the type of modification, and what it applied to). In this case, I'd suggest having:

  • "type: new feature"
  • "module: datasets"

What do you think? :)

@fharper fharper added type: enhancement Improvement module: datasets Related to doctr.datasets type: new feature New feature and removed type: enhancement Improvement labels Apr 27, 2022
@fharper
Copy link
Contributor

fharper commented Apr 27, 2022

@frgfm: awesome, I didn't even know, thanks!

@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: datasets Related to doctr.datasets type: enhancement Improvement type: new feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants