Theme + css #1 #856
Theme + css #1 #856
Conversation
fg-mindee
added
type: enhancement
There was a problem hiding this comment.
The new theme is quite nice thanks!
However, I'd argue there is one thing that was dropped and that shouldn't:
- the Google analytics ID (it's not used for ads at all, but this is the way Google Site Manager identifies the website and provides us with good SEO)
Is it not compatible with this theme?
|
Also, do you know if it's possible to reduce a bit the font size? (so that the title on the landing page fits by default) |
|
@fg-mindee |
Codecov Report
@@ Coverage Diff @@
## main #856 +/- ##
==========================================
+ Coverage 94.82% 94.84% +0.01%
==========================================
Files 133 133
Lines 5200 5200
==========================================
+ Hits 4931 4932 +1
+ Misses 269 268 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
docs/source/conf.py
Outdated
| @@ -114,6 +114,25 @@ | |||
| # A list of files that should not be packed into the epub file. | |||
| epub_exclude_files = ['search.html'] | |||
|
|
|||
| # Add googleanalytics id | |||
| # ref: https://github.com/sphinx-contrib/googleanalytics/blob/master/sphinxcontrib/googleanalytics.py | |||
There was a problem hiding this comment.
according to the ref https://github.com/sphinx-contrib/googleanalytics/blob/master/sphinxcontrib/googleanalytics.py#L30-L31
it looks like there are additional like to add 🤔
We have to make sure it's the correct way before moving on with this
There was a problem hiding this comment.
@fg-mindee I have updated this to a newer version.
But any idea how to test without deploy ?
There was a problem hiding this comment.
seems to be ok
https://www.googletagmanager.com/gtag/js?id=G-40DVRMX8T4
There was a problem hiding this comment.
Not sure how to test it, but worst case scenario, we can revert this
About your last URL, what is this supposed to be? 😅
There was a problem hiding this comment.
we don't have to set googleanalytics_id or googleanalytics_enabled then?
There was a problem hiding this comment.
@fg-mindee
Yes, I would also say that we try it !
We do not need to set googleanalytics_enabled it is only used if you use it as extension but we have integrated it directly so no need to set.
googleanalytics_id is only added to app.config to have a better overview we could set it also directly instead but i would say keep it
There was a problem hiding this comment.
URL shows that your id is set correctly with its configuration so i think it will work :)
{"function":"__gct","vtp_trackingId":"G-40DVRMX8T4","vtp_sessionDuration":0,"tag_id":1}
|
@fg-mindee |
fg-mindee
added
the
topic: documentation
#851