-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add shrinked target in linknet + dilation in postprocessing #822
Conversation
Codecov Report
@@ Coverage Diff @@
## main #822 +/- ##
==========================================
- Coverage 96.10% 95.97% -0.13%
==========================================
Files 131 131
Lines 4949 4988 +39
==========================================
+ Hits 4756 4787 +31
- Misses 193 201 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could do this in a smoother way by sharing the box shrink+dilation ops between the DB & LinkNet?
Because I feel like we're only adding duplicate lines of code here 😅
I modified the typo, for the code duplicates there is only the polygon_to_box part in common, I suggest refactoring that in another PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Charles!
Similarly to the DB, this PR includes a shrink of the polygons in the target and a dilation in the postprocessing of the linknet, to prevent boxes to be merged on the heatmap because their boundaries are too close.
After some experiments, this lead to much better results.
Any feedback is welcome!